bakerframework / bakercloud-ce-console

Repository for migration of the MagRocket Administration Console to the BakerFramework.
17 stars 7 forks source link

itunes ATOM feed API error, variable user_id undefined #26

Closed afurnas closed 10 years ago

afurnas commented 10 years ago

The ATOM feed crashes because line 449 in index.php references $user_id on the call to logAnalyticMetric function. Unfortunately, unlike most of the api calls, the ATOM feed does not pass user id and therefore the call crashes at this point.

I resolved locally by replacing $user_id with a blank string on the call to logAnalyticMetric

screen shot 2014-02-28 at 1 13 33 pm

nin9creative commented 10 years ago

Ah, that one slipped through the cracks...

afurnas commented 10 years ago

The quality of the application is so high that I was pretty sure I had configured something incorrectly. :) Thank you for a great app.

On Feb 28, 2014, at 2:34 PM, Andrew notifications@github.com wrote:

Ah, that one slipped through the cracks...

— Reply to this email directly or view it on GitHub.

nin9creative commented 10 years ago

Yeah, must not have tested that bit after adding in some additional analytics changes!

Andrew


From: Allen Furnas notifications@github.com To: bakerframework/bakercloud-ce-console bakercloud-ce-console@noreply.github.com Cc: Andrew andrew@nin9creative.com Sent: Friday, February 28, 2014 1:38 PM Subject: Re: [bakercloud-ce-console] itunes ATOM feed API error, variable user_id undefined (#26)

The quality of the application is so high that I was pretty sure I had configured something incorrectly. :) Thank you for a great app.

On Feb 28, 2014, at 2:34 PM, Andrew notifications@github.com wrote:

Ah, that one slipped through the cracks...

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

nin9creative commented 10 years ago

Just pushed a fix for this error in bakercloud-ce-api Master

https://github.com/bakerframework/bakercloud-ce-api/commit/d037d58e4c4431a44adf08bc4ba2bb968724f5ba