bakerkretzmar / laravel-deploy-preview

A GitHub Action to deploy PR preview sites for Laravel apps.
MIT License
19 stars 6 forks source link

Action does not create site on forge #15

Closed GlitchWitch closed 11 months ago

GlitchWitch commented 11 months ago

I am attempting to set this up in an existing repo but am not having much success.

I've used the following action config

# deploy-preview.yml
name: Deploy Preview
on:
  pull_request:
    types: [opened, closed, reopened, synchronize]
jobs:
  deploy-preview:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: bakerkretzmar/laravel-deploy-preview@v2
        with:
          forge-token: ${{ secrets.FORGE_TOKEN }}
          servers: |
            dev.app.REDACTEDORG.com 728116

And while the action seems to complete without error, no new site is created on the target forge server.

image

I have attempted the following steps to troubleshoot

I've attached the full output of the latest action run here but sadly there isn't much in the way of useful information.

Any help or direction would be much appreciated!

GlitchWitch commented 11 months ago

Found the issue!

It looks like https://github.com/bakerkretzmar/laravel-deploy-preview/blob/7bbb6ac7683eeed678f12b7e3ca8cc45ff693c3f/src/index.ts#L36 sets this to only run on PR open, since I was testing with existing PRs using the reopen and synchronize events nothing was happening.

I'll make a new issue and likely a PR to resolve this.