Fix boolean saved as string

bakerkretzmar / nova-settings-tool

Laravel Nova tool to view and edit application settings.

MIT License

167 stars 32 forks source link

Fix boolean saved as string #21

Closed FabioWidmer closed 5 years ago

FabioWidmer commented 5 years ago

After the changes in #19 boolean values got saved as strings. This pull request fixes this problem. Empty text or textarea fields are already correctly saved as null. Please make sure the settings.json does not already contain the wrong value "null" because it will take this value if you want to update it as an empty field.

FabioWidmer commented 5 years ago

@bakerkretzmar It would be great if you could review this pull request and make a new release if everything works as expected now 😄.

bakerkretzmar commented 5 years ago

@FabioWidmer I really appreciate the time you've put into this—I'm going to hold off for now, I think this might be better solved at the same time as implementing validation, which I've been meaning to do as well soon. I'll have time to tackle this in a few weeks. Thank you!