POM CV writes interpret railcom returns incorrectly

bakerstu / openmrn

OpenMRN (Open Model Railroad Network)

BSD 2-Clause "Simplified" License

57 stars 28 forks source link

POM CV writes interpret railcom returns incorrectly #517

Closed balazsracz closed 3 years ago

balazsracz commented 3 years ago

in the openlcb/*CVSpace.cxx we interpret the returned railcom feedback. The code there is not compliant to the standard. Specifically, a write is only acknowledged as done by the decoder when it sends back a readout of the same CV. Sending back an ACK is not a positive acknowledgement of a successful write according to the standard.

atanisoft commented 3 years ago

@balazsracz was this fixed as part of PR https://github.com/bakerstu/openmrn/pull/560?

balazsracz commented 3 years ago

Fixed by #560.