search

baking-bad / netezos

Netezos is a cross-platform Tezos SDK for .NET developers, simplifying the access and interaction with the Tezos blockchain
https://netezos.dev
MIT License
40 stars 21 forks source link

Make PostAsync() overrideable #14

Closed sshine closed 4 years ago

sshine commented 4 years ago

In ForgeOperationsQuery, public Task<JToken> PostAsync(string contents) is being overridden, but PostAsync in RpcPost is not marked as virtual.

This commit assumes that all PostAsync methods in RpcPost are allowed to be overridden even though only one is currently being overridden.

And it marks that one case with override.

Note that this change was necessary to be able to run tests for #13.

sshine commented 4 years ago

Let me know if this issue needs to be resolved in another way than proposed here.

Groxan commented 4 years ago

Thank you for the PR! That method was actually placed there mistakenly, as it does nothing, so it's better to simply removed it 🙂