baking-bad / pysignalr

Modern, reliable and async-ready client for SignalR protocol
MIT License
18 stars 6 forks source link

Accesstoken factory and connection id #4

Open chrisism opened 2 years ago

chrisism commented 2 years ago

It would be nice to be able to apply an accesstoken factory method, generating the authentication tokens for secured connections. Also we need a way to get the connection id to setup grouped and channel specific communication.

droserasprout commented 2 years ago

Hi, and thanks for reaching out!

These features seem to be relatively easy to implement since they were present in mandrewcito/signalrcore, which this project is inspired. However, PRs are very welcome since we don't need this functionality in our project.

mgkeeley commented 4 months ago

I am interested in using this package, and need this auth feature for our project also. ❤️

However, may I suggest that the token method is made async? Often the token method would make calls to update a refresh token, or exchange credentials for a access token.