search

baking-bad / pytezos

🐍 Python SDK for Tezos | Michelson VM in Python
https://pytezos.org
MIT License
112 stars 38 forks source link

Consider splitting pytezos.crypto into a separate pip package #284

Closed elric1 closed 8 months ago

elric1 commented 2 years ago

The smaller package would be of use in at least two projects with which I am involved to reduce the size of our generated docker images.

aliel commented 2 years ago

Up

hoh commented 2 years ago

Installing Pytezos currently requires approximately 141 MB of dependencies, including Jupyter and other libraries that are not useful for checking signature and other cryptographic operations.

droserasprout commented 2 years ago

Hi, thanks for bumping this!

Merging the Jupyter kernel into the main repo helped us to establish a single release cycle between those. I think it's the right time to go further and split something like the pytezos-core package out of the main repo.

Do you think pytezos.crypto will be sufficient? May forging/unforging or RPC wrappers also come in handy?

elric1 commented 2 years ago

For my purposes, pytezos.crypto is sufficient.

hoh commented 2 years ago

pytezos.crypto would also be sufficient for my usecases.

aliel commented 2 years ago

Hello, we forked the crypto part available here => https://github.com/aleph-im/aleph-pytezos

droserasprout commented 2 years ago

Sorry about the delay. I'm still unsure about how to implement this one since Poetry - a tool we use for packaging - has no native monorepo support—going to figure it out in the next few days.

droserasprout commented 2 years ago

@aliel, @elric1, could you please try the following images:

$ docker pull ghcr.io/baking-bad/pytezos-core:1.0.0rc1
$ docker pull bakingbad/pytezos-core:1.0.0rc1

Does everything work as expected?

UPD: New images!

droserasprout commented 8 months ago

After some consideration we decided that maintaining a separate package would be too time consuming despite being technically possible. Our latest Docker image is 122MB uncompressed, which isn't perfect, but, well, competitive I think. Closing this issue as wontdo.

Please, don't use pytezos-core 1.0.0rc1 prerelease image and Python package as they are very outdated.