Closed konchunas closed 1 year ago
Hey! Thanks for the fix, indeed I haven't considered this case.
It's ok, better leave iter_comb
as it is.
Seems that integration tests are falling due to the node, can I please ask you to replace https://github.com/baking-bad/pytezos/blob/ec5482ef02f9722bdea50d99cedd0bb01452e60f/src/pytezos/context/mixin.py#L32 with 'mainnet': ['https://rpc.tzkt.io/mainnet'],
?
Integration tests passed without problems now
Thank you! Merging
I had an
UNPAIR 8
operation on the following pair:Current Pytezos implementation takes every second element of a pair and unpairs it, regardless of N. This approach failed for me on assert with
expected 8 leaves, got 9 leaves
. It happens because the very last item(0 * 0)
is also a pair and it gets unpaired. I've made this example implementation which actually unpairs 8 elements instead.Marking this pull request as a draft, cause it might be better to add a
count
toiter_comb
function.