Closed igorsereda closed 4 months ago
1β110 testsβ Β±0βββ1β098 :white_check_mark: Β±0βββ1m 45s :stopwatch: -19s ββββ4 suites Β±0ββββββ12 :zzz: Β±0β ββββ4 filesββ Β±0βββββββ0 :x: Β±0β
Results for commit ddee28ab.βΒ± Comparison against base commit 85a7ce83.
1β110 testsβ Β±0βββ1β098 :white_check_mark: Β±0βββ2m 5s :stopwatch: -1s ββββ4 suites Β±0ββββββ12 :zzz: Β±0β ββββ4 filesββ Β±0βββββββ0 :x: Β±0β
Results for commit ddee28ab.βΒ± Comparison against base commit 85a7ce83.
:recycle: This comment has been updated with latest results.
I tried to understand what was happening here and why this constant affects transactions at all.
As far as I understand, this MAX_OPERATIONS_TTL
is used to calculate the branch
here. As far as DEFAULT_OPERATIONS_TTL
is 5
the branch
will be equal to the head~115
block hash. And then the OperationGroup
spawned with this branch, right?
Not sure why this logic is required, why not use more recent blocks?
I suppose this is because before Tenderbake (about two years ago) there was no finality and there was a chance that the chain would be forked, can someone confirm?
Anyway, I checked that this works both in the pariscnet
and mainnet
, so looks good to me.
This PR fixes errors like