search

baking-bad / tzkt

😼 Awesome Tezos blockchain indexer and API
https://tzkt.io
MIT License
183 stars 35 forks source link

Please migrate to .net 7 (or at least 6) #131

Closed ac10n closed 1 year ago

ac10n commented 1 year ago

We are using TzKt in Taqueria to index a local Flextesa sandbox. It runs on dewveloper's computer and works very well except:

It does not run on mac m1

I have migrated the project to .net 6 and it's working fine. Additional changes to the CI will be needed to create the multi-architecture docker image. But I guess I can contribute that as well.

So the question is: is there any reason to stay on dotnet 5? Or if we contribute the change there's a high chance for it to be merged?

Thanks

Groxan commented 1 year ago

Thank you for the suggestion! We don't want to update to .NET 6, because there is a bug in JsonSerializer, which is fixed in .NET 7 only. So, yeah, we had plans to update to .NET 7, but only when a more or less stable version is released. Finally, 7.0 (not preview) has been released three days ago, so I think from now we can start migration :slightly_smiling_face:

It's actually not just about changing the target framework when building, but also we have to accurately check all the breaking changes in both .NET 6 and .NET 7 and adjust the code if needed, to ensure nothing will be broken in the indexer.

ac10n commented 1 year ago

Thank you very much