bakins / php-fpm-exporter

Prometheus exporter for php-fpm status.
MIT License
203 stars 46 forks source link

fix #20 - check if URL is an empty string #26

Closed rthornton128 closed 5 years ago

rthornton128 commented 5 years ago

It is not necessary to check for empty strings in the raw URLs as the associated DIal functions will fail appropriately. However, in the case of FastCGI you want to default to HTTP so checking for an empty URL is needed.

You would be able to remove the checks adding in commit 9a63716c8569bcdbb071d375ba4d188f6bc976f6 with this patch.

bakins commented 5 years ago

LGTM