Fuzzy Highlighting has small graphical glitches

bakkeby / dmenu-flexipatch

A dmenu build with preprocessor directives to decide which patches to include during build time

MIT License

183 stars 78 forks source link

Fuzzy Highlighting has small graphical glitches #12

Closed JimPix1 closed 2 years ago

JimPix1 commented 2 years ago

I've noticed for a while now that the dmenu highlighting is a bit glitchy, specifically with certain letters, e.g: If you look carefully there is a blue line just before every highlighted M, which is weird.

JimPix1 commented 2 years ago

I've noticed this in both the latest build and the build I use right now (From February the 3rd) The patches I have are alpha

border
center
fuzzyhighlight
fuzzymatch
grid
lineheight
morecolor
mousesupport
numbers
password
restrict return
color emoji

bakkeby commented 2 years ago

This seems to happen with the fuzzy highlight patch, but not the highlight patch.

JimPix1 commented 2 years ago

Righto, issue renamed then :+1:

bakkeby commented 2 years ago

This only happens when lrpad is an odd number, i.e. it depends on the font and the font size. The issue has to do with deducting lrpad / 2 from the text width which means that the x variable ends up being positioned 1 pixel too far to the right when overwriting the text with the highlight.

JimPix1 commented 2 years ago

So should I change the font size or?

bakkeby commented 2 years ago

With the above change it should look fine. I'd expect the original patch on the suckless site to have the same issue.

JimPix1 commented 2 years ago

Ah, brilliant! It works perfectly now. Thanks Bakkeby :) All that needs to be fixed now is #11 and I'll be able to update my dmenu-flexipatch build again