bakkeby / dusk

Just another fork of dwm
MIT License
154 stars 21 forks source link

Arabic and Right-to-Left Languages is NOT rendered Correctly. #19

Closed tempusernameforunixy closed 11 months ago

tempusernameforunixy commented 11 months ago

Hi @bakkeby thanks for this amazing fork of DWM it's working great; but there is a simple problem with an easy fix and it's that Arabic and right-to-left languages are not rendered probably on the bar, it looks like this. image

bakkeby commented 11 months ago

I was thinking of adding this as a patch, but maybe it is OK to add this as an optional dependency.

Taking a random YouTube video as an example test case:

Without the patch: image

With the patch: image

The video title on the site, however, looks like this: image

In our case, using the fribidi library, we reverse the whole text, whereas it looks like on YouTube the RTL text sections are reversed while the general composition of the text is kept. Not sure which method is more correct, I'd assume that the fribidi way makes more sense.

bakkeby commented 11 months ago

To test these changes all you need, besides having the fribidi library installed, is to uncomment the following lines in config.mk:

https://github.com/bakkeby/dusk/blob/6c4d3da2fb6b224ce70b557664cb4d00e33aa2e0/config.mk#L22-L25

tempusernameforunixy commented 11 months ago

Thanks alot @bakkeby for the fast response and active development of this great project. i have tested it and it worked as intended, here is my test case: image

Thanks, C ninja ;)