bakkeby / dusk

Just another fork of dwm
MIT License
154 stars 21 forks source link

ViewOnWS does not work #21

Closed Nazushvel closed 7 months ago

Nazushvel commented 7 months ago

Looks like currently behavior with both ViewOnWS enabled/disabled is the same. leaving it commented out still switches workspace when you move a window and does the same when it is uncommented.

Also to confirm I tried it unmodified and got the same result.

Also, thanks for this awesome application. Been looking for something to fit my workflow for years and looks like this is just what I have been looking for.

Nazushvel commented 7 months ago

Well I feel dumb, I see now that shift does that and ctrl does not. Guess I should have read the instructions a bit better. Closing as non issue

bakkeby commented 7 months ago

Yes. To give a bit more context for other people reading this the ViewOnWs functionality intends to mirror the viewontag patch for dwm which makes the view follow the tag a window is being moved to.

But that feature makes it always the case when moving windows around, and sometimes you may want to:

As such the behaviour was split into two separate functions:

https://github.com/bakkeby/dusk/blob/acedf00c7289a2843b0e78b2c101f41f7401b5c0/config.def.h#L453-L460

Now, what is the purpose of the ViewOnWs functionality in dusk then considering that this is controlled by different functions?

The functionality toggle controls the default behaviour for other scenarios where clients are being moved around. For example movewsdir, movews, movealltowsbyname, clienttomon, clientstomon, or when _NET_ACTIVE_WINDOW client messages are received and the FocusOnNetActive functionality is enabled.