Closed 0xGodspeed closed 2 years ago
Hi @godspeed-x, hmm, I'll have a closer look at why that is. In the meantime enable PERTAG_VANITYGAPS_PATCH
as well.
Just committed a fix for that, thanks for reporting.
The PERTAG_VANITYGAPS_PATCH
is a pertag option to remember gap sizes on a per tag basis. Introducing that led to a bug where the gaps would not be enabled by default (but could be enabled if you were to use togglegaps).
Thanks! I cloned the repo again and the gaps are working now without PERTAG_VANITYGAPS_PATCH
but I can't toggle the gaps on/off.
If I enable the pertag patch as well, then it works.
Yes maybe it is better that PERTAG_VANITYGAPS_PATCH
controls both remembering gap sizes per tag as well as whether gaps are enabled per tag.
So there is no way to toggle gaps without the patch?
It used to be that if you had vanitygaps and pertag enabled then it would automatically also remember whether gaps were enabled per tag.
Then later the option to remember different gap sizes on a per tag basis was introduced as well. As some may prefer not to have different gap sizes on a per tag basis this was made configurable.
As this was now configurable it wasn't entirely clear whether tags should be toggleable on a per tag basis automatically or not, hence the initial bug you reported.
I think it is more logical that PERTAG_VANITYGAPS_PATCH
controls both features.
You will be able to toggle gaps in both cases. It will be similar to the pertag bar patch which allows you to toggle the display of the bar on and off on a per tag basis.
You will be able to toggle gaps in both cases. It will be similar to the pertag bar patch which allows you to toggle the display of the bar on and off on a per tag basis.
I can't toggle gaps without PERTAG_VANITYGAPS_PATCH
You should be able to after the last commit.
It is working after the last commit. Thanks a lot.
@bakkeby thanks for fixing it!
One question, I'm using three-column layout, any chance to get the gaps there too? I've just started experimenting with dwm and can't wrap my head around it yet :)
@desprit how is the three column layout different from the centeredmaster layout?
@bakkeby I haven't tried centeredmaster but from the screenshots it looks like centeredmaster may have a stack of masters while threecolumn layout always has one master in the middle of the screen; new windows are added to the left and right.
@desprit I think the three column layout is older than the nmaster patch, hence you can only have one client in the master area. I'd recommend that you try that one out first. You also get all of these layouts with flextile-deluxe, but that's a bit of an overkill.
@bakkeby Works perfectly for me, thank you!
I installed dwm after enabling vanity gaps and some other patches. Everything except the gaps seem to be working. I think the patch has been applied since there are keybindings related to increasing and decreasing gaps in the config but they don't work either. How do I fix this? Thank you
config.h
patches.h