search

bakkeby / dwm-flexipatch

A dwm build with preprocessor directives to decide which patches to include during build time
MIT License
1.18k stars 239 forks source link

Some minor optimizations about FAKEFULLSCREEN_PATCH #393

Closed ysl2 closed 1 year ago

ysl2 commented 1 year ago

You could check the commit's title for more information. Just some minor modifications.

The first is to set lockfullscreen to zero when fakefullscreen is enabled, so that we can change the focus. Otherwise, the focus still be the fakefullscreened client, and we can't move focus to another.

The second is when using touchpad, and the fakefullscreen is enabled, the fakefullscreened client, in fact, is just like a normal client. Especially when it is also floated. So it should can be resized. For example, when playing a video in a float client and set it to fakefullscreen.

I have tested these two commits, they worked well as I expected.

Update: I think if this might only be my personal preferences and should not be merged in mainline? Because these are not bugs, just some small features. But I also think these are most people would like to do.

bakkeby commented 1 year ago

I'd consider it as a patch compatibility issue.

Should change it to:

https://github.com/bakkeby/dwm-flexipatch/blob/332c90049d5fd08a35b4e2e73312d9d5536e3e62/dwm.c#L3042-L3050

As for the lockfullscreen config, tbh I'd be tempted to just set that to 0 in the default configuration. I think it was silly to add that in the first place given that the feature is isolated to the focusstack function.