search

bakkeby / patches

Collection of patches for dwm, st and dmenu
286 stars 30 forks source link

tabbed-bottomtabs patch for tabbed doesnt work #35

Closed siduck closed 3 years ago

siduck commented 3 years ago

Hi @bakkeby thanks for making the bottomtabs patch for tabbed , it doesnt seem to work for me . And the tabs arent clickable with mouse either and the tabs arent visible. Also they just show when I make the terminal fullscreen.

https://user-images.githubusercontent.com/59060246/126968346-71959d44-5d5d-4ac2-87f3-6db1e7504b5a.mp4

bakkeby commented 3 years ago

I can see the mouse click issue, but not sure how to reproduce your other issue about the tabs not showing.

bakkeby commented 3 years ago

I guess the autohide patch is interfering.

siduck commented 3 years ago

unpatching autohide works.

bakkeby commented 3 years ago

https://tools.suckless.org/tabbed/patches/autohide/tabbed-autohide-20201222-dabf6a2.diff

Line 37, 38 we have this:

+       for (i = 0; i < nclients; i++)
+           XMoveResizeWindow(dpy, clients[i]->win, 0, bh, ww, wh - bh);

this can be fixed with by setting the y position of bh to 0.

+       for (i = 0; i < nclients; i++)
+           XMoveResizeWindow(dpy, clients[i]->win, 0, 0, ww, wh - bh);