search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
347 stars 107 forks source link

use NETWMICON-0.8.5-v2 #101

Closed ItzSelenux closed 5 months ago

ItzSelenux commented 1 year ago

on 2022-06-04, the patch was updated, but this repo added the patch on 2021-05-08 and not updated it since it, this pull request use the updated code of the patch that uses a png file (/usr/local/share/st.png), this way is better than the hardcoded icon

bakkeby commented 6 months ago

I am very sorry, this has been waiting around for a very long time.

Your proposed changes are fine, but I don't entirely agree with the patch author that this is a patch upgrade as such as it seems like more of a patch variant.

Although the original patch had a hardcoded icon it was also a very simple patch, and perhaps that was enough for some people.

I don't disagree that using a png file is more convenient if you want to use a custom icon for st, but it does add dependency on another library.

I think that this can be merged in, but I am thinking that it may be worth keeping the original patch as well - maybe renaming the patch toggle to NETWMICON_LEGACY_PATCH.

To be honest I'd be interested to see a farbfeld variant of this patch. Should in theory be relatively simple to read the RBGA image format and convert it to ARBG without the need for any additional libraries.

bakkeby commented 5 months ago

Closing this in favour of #121.