bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
347 stars 107 forks source link

Remove black bars from sixel images #103

Closed veltza closed 9 months ago

veltza commented 11 months ago

When the images don't fully cover the text cells, black bars are added to them. This fix removes those bars, but if you need the old behavior, you can restore it by setting 'sixelremovebars' to zero in config.h

Ref. https://github.com/bakkeby/st-flexipatch/issues/102#issuecomment-1719963168

veltza commented 9 months ago

A simpler solution would be to use the current background color.

bakkeby commented 9 months ago

Sorry I must have missed this, have a lot going on. Are you raising a new PR with changes?

veltza commented 9 months ago

I could, and that would also solve the transparency issues. Technically, the sixels do not have transparency, but empty pixels would be rendered with the current background color instead of black to make them appear transparent. Even though the solution is simple, the alpha patches might complicate it a bit, but let's see.