search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
347 stars 107 forks source link

Add selectioncolors patch #110

Closed JCallicoat closed 6 months ago

JCallicoat commented 6 months ago

Changes mode in Glyph struct from ushort to uint32_t per https://github.com/bakkeby/st-flexipatch/issues/91#issuecomment-1918439030 and adds latest version of selectioncolors patch.

veltza commented 6 months ago

Sorry to interrupt, but it looks like the bit 14 is still free in the glyph attributes. So there should be no need to increase the size of the bitfield.

JCallicoat commented 6 months ago

Sorry to interrupt, but it looks like the bit 14 is still free in the glyph attributes. So there should be no need to increase the size of the bitfield.

Oh looks like you are right, nice catch. @bakkeby should I back out the change to uint32_t and just use bit 14 here and you can deal with increasing the size if needed for other patches in the future?

bakkeby commented 6 months ago

Yes let's just use bit 14 then and change the data type later if needed. The code changes themselves look good.

There is potentially a conflict with the dynamic cursor color patch, but not sure how one might expect them to work together in this context so probably fine letting selection colors take precedence here.

JCallicoat commented 6 months ago

Done.

bakkeby commented 6 months ago

Thanks @JCallicoat.