search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
347 stars 107 forks source link

sixtel with tmux 3.4 no image is shown #111

Closed step- closed 6 months ago

step- commented 6 months ago

I updated to tmux 3.4, which supports sixel images when compiled with --enable-sixel. It appears that st-flexipatch with SIXTEL_PATCH shows an empty rectangle instead of an image. I read all open and closed sixtel issues on https://github.com/tmux/tmux/issues but I couldn't find a solution. I applied all the points they mention:

I tested several sixtel images downloaded from the issues pages. Sixtel support works outside tmux with TERM=st-256color but doesn't work when tmux is running with inside TERM=tmux-256color. My patches.h file is attached.

So I wonder if anyone could please test st-flexipatch with tmux 3.4 and confirm if sixtel images work for them. Thank you.

patches.h.txt

left: st outside tmux; right: st running tmux

st-sixtel-20240228

bakkeby commented 6 months ago

Hi @step-,

can you try @veltza's st-sx build?

It has quite a few improvements when it comes to sixel support and it may potentially work there.

step- commented 6 months ago

Hi @bakkeby, thanks. Tried and yes, sixtel inside tmux works in st-sx.

bakkeby commented 6 months ago

Right, OK. The plan is to integrate those changes into st-flexipatch ref. #102.