search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
353 stars 108 forks source link

Externalpipe patch not working with the reflow patch #122

Closed UtkarshVerma closed 7 months ago

UtkarshVerma commented 7 months ago

I noticed that both of these patches don't work together.

Steps to reproduce

  1. Get source: https://github.com/UtkarshVerma/st-flexipatch
  2. Compile and run.
  3. Invoking externalpipe should cause segfault. (Press <Ctrl><Shift>u or <LAlt>u.
step- commented 7 months ago

Related: gcc warns about a pointer from integer cast in patch/externalpipe.c.

(The linker error in the log file is probably unrelated to the current issue. I still need to investigate that.)

bakkeby commented 7 months ago

It seems to just be that one line that was causing issues. Can you let me know if this solved it for you?

UtkarshVerma commented 7 months ago

Thanks for the quick fix. It works now.