search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
363 stars 109 forks source link

scrollback ringbuffer patch #61

Open apprehensions opened 2 years ago

apprehensions commented 2 years ago

https://st.suckless.org/patches/scrollback/st-scrollback-ringbuffer-0.8.5.diff i personally don't know the differences between this new scrollback patch that uses a ring buffer. t is also said that it is "more efficient" in scrolling. and if this is quite better, is there a way to port the column reform patch to this ringbuffer scrollback patch? and also add it to st-flexipatch?

bakkeby commented 2 years ago

I'd assume that the difference would be how the scrollback logic works internally and that from an end user's point of view there would be no noticeable difference between the two.

I tried the patch and it seems to work and it doesn't allow you to scroll further up than there is buffer.

I didn't have any luck getting mouse scrolling work with this patch for whatever reason.

The columns patch is a rather invasive one and not sure how easy it would be to integrate that with this new ringbuffer patch (as the column patch is largely designed around / with the original scrollback patch I presume).

The columns reflow patch is at least three times as invasive as the columns patch, so this sounds both painful and less likely.

Using tmux (which st seems to be designed around) makes all of the aforementioned patches redundant although scrolling may be a bit more of a hassle.