search

bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
347 stars 107 forks source link

extract sixel patch #90

Closed apprehensions closed 1 year ago

apprehensions commented 1 year ago

hello, is it possible that the sixel patch from this repository (assuming it works), can be extracted for manual patching use?

bakkeby commented 1 year ago

You are welcome to try :)

speedie1337 commented 1 year ago

I haven't been able to get the sixel scrollback to work perfectly but I found and updated an old diff. (See top of the patch)

It may have more issues, but it works well enough on my personal st build. Diff

image

apprehensions commented 1 year ago

the diff you gave contains more than the sixel patch, is it okay if it only contains the sixel patch?

apprehensions commented 1 year ago

You are welcome to try! :)

20221202_193513_sc

speedie1337 commented 1 year ago

the diff you gave contains more than the sixel patch, is it okay if it only contains the sixel patch?

It shouldn't, what extra feature does it contain? If you look at the top of the diff you can see the source of the original diff.

apprehensions commented 1 year ago

considering that i want to use scrollback and scrollback reflow alongside sixel, i think this is gonna be a HUUUUUUUGE headache, considering i don't know C.

speedie1337 commented 1 year ago

It doesn't seriously conflict with scrollback in terms of the patch applying but scrolling doesn't move the image. There was an issue here about it a while ago that you might be able to follow.

apprehensions commented 1 year ago

@speediegq thanks for your diff! but, whats with the black borders of the image?

speedie1337 commented 1 year ago

@speediegq thanks for your diff! but, whats with the black borders of the image?

Don't really know, and it didn't really bother me so I haven't spent much time trying to figure it out.

apprehensions commented 1 year ago

yeah i guess the sixel patch does have some problems, like the image being perfectly still after terminal size change..

speedie1337 commented 1 year ago

It does have issues, sixel really isn't great in my opinion anyway.

I would tell you to use Ueberzug but the author has deleted that project so until there's a fork, you can either use that old version based on an old commit, w3m which barely works or sixel which doesn't work all that great in most terminal emulators, and images don't look as nice either.

apprehensions commented 1 year ago

I would tell you to use Ueberzug

I have, i don't think it's very nice and the reference implementation - albeit still really fucking hard, is quite nice as it isn't on a manual Python X11 drawing program.

apprehensions commented 1 year ago

i give up with sixel