bakkeby / st-flexipatch

An st build with preprocessor directives to decide which patches to include during build time
MIT License
353 stars 108 forks source link

undefined references while building with sixel #94

Closed apprehensions closed 1 year ago

apprehensions commented 1 year ago

with this patches.h:

#define ALPHA_PATCH 1
#define BACKGROUND_IMAGE_PATCH 0
#define BLINKING_CURSOR_PATCH 1
#define BOLD_IS_NOT_BRIGHT_PATCH 1
#define BOXDRAW_PATCH 1
#define CLIPBOARD_PATCH 1
#define COLUMNS_PATCH 1
#define COPYURL_PATCH 0
#define CSI_22_23_PATCH 1
#define DELKEY_PATCH 1
#define DYNAMIC_CURSOR_COLOR_PATCH 1
#define EXTERNALPIPE_PATCH 0
#define EXTERNALPIPEIN_PATCH 0
#define FIXKEYBOARDINPUT_PATCH 1
#define FULLSCREEN_PATCH 1
#define HIDECURSOR_PATCH 1
#define HIDE_TERMINAL_CURSOR_PATCH 0
#define ISO14755_PATCH 0
#define NETWMICON_PATCH 1
#define NEWTERM_PATCH 1
#define OPENCOPIED_PATCH 0
#define OPENURLONCLICK_PATCH 1
#define SCROLLBACK_PATCH 1
#define SCROLLBACK_MOUSE_PATCH 1
#define SCROLLBACK_MOUSE_ALTSCREEN_PATCH 1
#define SIXEL_PATCH 1
#define SPOILER_PATCH 0
#define SWAPMOUSE_PATCH 1
#define SYNC_PATCH 1
#define USE_XFTFONTMATCH_PATCH 1
#define WIDE_GLYPHS_PATCH 1
st build options:
cp config.def.h config.h
c99 -I/usr/X11R6/include  `pkg-config --cflags fontconfig`  `pkg-config --cflags freetype2`   -DVERSION=\"0.9\" -D_XOPEN_SOURCE=600  -O2 -pipe -march=native -c st.c
c99 -I/usr/X11R6/include  `pkg-config --cflags fontconfig`  `pkg-config --cflags freetype2`   -DVERSION=\"0.9\" -D_XOPEN_SOURCE=600  -O2 -pipe -march=native -c x.c
CFLAGS  = -I/usr/X11R6/include  -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz  -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz   -DVERSION="0.9" -D_XOPEN_SOURCE=600  -O2 -pipe -march=native
LDFLAGS = -L/usr/X11R6/lib -lm -lrt -lX11 -lutil -lXft   -lfontconfig -lfreetype  -lfreetype   
CC      = c99
c99 -o st st.o x.o -L/usr/X11R6/lib -lm -lrt -lX11 -lutil -lXft   `pkg-config --libs fontconfig`  `pkg-config --libs freetype2`   
/usr/bin/ld: st.o: in function `strhandle':
st.c:(.text+0x3d0d): undefined reference to `sixel_parser_finalize'
/usr/bin/ld: st.c:(.text+0x3d1f): undefined reference to `sixel_parser_deinit'
/usr/bin/ld: st.o: in function `tputc':
st.c:(.text+0x4a6f): undefined reference to `sixel_parser_init'
/usr/bin/ld: st.c:(.text+0x57b2): undefined reference to `sixel_parser_parse'
/usr/bin/ld: st.o: in function `strhandle':
st.c:(.text+0x3f41): undefined reference to `sixel_parser_deinit'
collect2: error: ld returned 1 exit status
make: *** [Makefile:33: st] Error 1
bakkeby commented 1 year ago

I added a note about this in #25, you need to uncomment the corresponding lines in config.mk when enabling the sixel patch.

https://github.com/bakkeby/st-flexipatch/blob/a8e2af0d923e7b6f7b19e8fa516bcd0670dfae84/config.mk#L27-L28

apprehensions commented 1 year ago

you should have just said 'YOU IDIOT!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!' because i didn't read the comment.