bakkenbaeck / Teapot

A light-weight URLSession wrapper for building simple API clients.
MIT License
19 stars 3 forks source link

Improved error handling, added more information and a description. #16

Closed elland closed 7 years ago

elland commented 7 years ago

Moved errors from enums to structs (apparently that was always a thing), so now our errors have more contextual information (like the actual status code that triggered it), and a localisable description.

Fixes #15.

elland commented 7 years ago

Currently looking into a better way to handle localisation, suggestions welcome.

elland commented 7 years ago

Changes are up. ✨

elland commented 7 years ago

wrt overriding the bundle: You can override or you can set, it won't matter as long as it's done before you use it. 👌

marijnschilling commented 7 years ago

Yeah... I'm just wondering for toshi where would be a logical place to set it...

I will fix the MockTeapot errors in antoher branch btw!