search

bakkerij / notifier

Notifications plugin for CakePHP 3.x
MIT License
59 stars 38 forks source link

CakePHP update #17

Closed b1scuit closed 8 years ago

b1scuit commented 8 years ago

CakePHP version updated to 3.3.X, strongly advise running composer update before installing however this allows CakePHP to meet install requirements on new installs of the notifier

bobmulder commented 8 years ago

Thanks for noticing, however on line 2 of the composer.json you changed the name... Why? :P

b1scuit commented 8 years ago

ahh sorry, I though I was pushing to my own branch, feel free to dich that

b1scuit commented 8 years ago

all back to how it was :-)

bobmulder commented 8 years ago

Great! Thanks! However because you spent 7 commits to one rule, can you squash your commits? (See http://couscous.io/contributing.html for more info)

b1scuit commented 8 years ago

I am utterly confused by this and have no idea how to squash them im afraid, this page may as well be in arabic

b1scuit commented 8 years ago

Closed pull request to open a cleaner one since squashing commits may as well be nuclear science