bakkesmodorg / BakkesModInjectorCpp

C++ rewrite of the BakkesModInjector
67 stars 21 forks source link

BM out of date but not really #17

Open Toomoch opened 3 years ago

Toomoch commented 3 years ago

I use an alternative epic launcher called legendary, so I don't have epic installed or the game installed on the Epic Games folder in program files. I have the latest version on bakkes and RL installed, but it tells me this: imagen If I disable safe mode, it launches and works but it's not ideal. Version info displays this: imagen it says that I have version 309642 even through the version installed is 321643b Where does the mod get the installed epic version from and why is it wrong? Thanks

sadn1ck commented 3 years ago

can you try disabling settings->disable warnings and check? i had that problem as well (albeit on linux) and then it checked for updates (never got it working though sad)

Kyle2142 commented 3 years ago

on a related note, I also use legendary and it said my game was up to date (I can play online) but launching epic still had another update. After that update, Bakkesmod worked (well, was compatible. I didn't try turning safe mode off)

raycekar commented 1 year ago

I know this is old, but diggin in the code, I presume the "GetEpicVersion()" function on line 445 of file BakkesModInstallation.cpp is what would need to be maybe updated in some way.

From what I can see, the function is looking into directory C:\ProgramData\Epic\EpicGamesLauncher\Data\Manifests for a .item file in a json format. In that file, it has "MandatoryAppFolderName" and "LaunchExecutable" that it checks before looking for "AppVersionString".

I presume you could boilerplate this file and configure its values to be to your legenday install location, but i assume the version would have to be manually updated each time. If someone happens to have Epic installed with RL, I would be curious to see what that file looks like.

EDIT/UPDATE: So my theory was right. You can create this file and bakkas mod will detect it as RL Epic version and no warnings come up. So to have it work yourself:

  1. Create a .item file in C:\ProgramData\Epic\EpicGamesLauncher\Data\Manifests and name it whatever you want. I named my RL_Legendary.item
  2. paste the following code in it: { "MandatoryAppFolderName": "rocketleague", "LaunchExecutable": "RocketLeague", "AppVersionString": "BC2_Update40+407707" }
  3. Sadly now when you get an update, I think you will have to manually update the AppVersionString.

I think it would be nice if we could have bakkasmod go off the manifest file name that legendary downloads or creates as the filename includes the version.

raycekar commented 1 year ago

Update: see #28