Consistency improvements.

bakkesmodorg / BakkesModSDK

The current BakkesModSDK (Unofficial SDK for Rocket League)

http://bakkesmod.com

223 stars 49 forks source link

Consistency improvements. #37

Closed ItsBranK closed 2 years ago

ItsBranK commented 2 years ago

Fixed up some random spaces and new lines to make more consistent, along with brackets in wrapperstructs.h.
Replaced unsigned long long with uint64_t.
Replaced unsigned int with uint32_t.
Replaced int with int32_t.
Replaced unsigned char with uint8_t.

Bakkes commented 2 years ago

While I do like using these new types in modern projects, I think I'd rather keep the oldschool ones for this to keep it in line with the original Windows UE3 typedefs instead of using another layer of indirection. The only other thing I've thought about changing is the unsigned long for bool fields to a forced 4 byte type, since an unsigned int was used in the Linux port (as unsigned longs are 8 bytes there), but since that's dead and it might break ABI I probably shouldn't do that.

Let me know if you have strong thoughts on it, but I'm not planning on changing it currently for the above reason as well as we'd also have to change most of the types internally for consistency.

ItsBranK commented 2 years ago

I am going to cry