search

bakpakin / Fennel

Lua Lisp Language
https://fennel-lang.org
MIT License
2.42k stars 124 forks source link

Fix failing tests. #466

Closed bb010g closed 11 months ago

bb010g commented 11 months ago

Tested via nix build ".#fennelCheckAll".

This includes a minor compatibility fix for Faith that probably needs to be upstreamed.

technomancy commented 11 months ago

Thanks. We will keep the packaging in downstream repos instead of in this one, but we can probably take the second commit.

Can you say a little more about this change in the commit message? Under what circumstances is the change to include needed?

I don't understand what the compatibility changes for faith.fnl are for either; load is never mentioned in the file, and the original math.pow exists in all supported Lua versions.

technomancy commented 11 months ago

Looking at this more closely, I can see that the actual fix is just a 2-line revert of a mistaken change from 5c803e426a5fff59ace6ab7520d14be63cb93c6e. I've committed this fix in its own commit with a descriptive commit message in order to get the tests passing on main again.

If you want to land some of the other changes to the tests (without the downstream packaging changes) we can talk about those separately. Thanks!