sogaiu
commented
3 years ago Added a commit to check for name collisions and if detected, respond by constructing a name that has not been used already.
There is now a table that stores names along with corresponding integer counts.
The integer is used as a basis for a new suffix for the id in case of collisions. Each time a collision is detected, the integer in the table is incremented.
Also, instead of stripping inner space characters, they are replaced with "-". Leading and trailing space characters are trimmed.
I don't understand how mendoza works well enough to know whether this table needs to be wiped from time-to-time.
pepe
bakpakin
This is an initial sketch of providing an id attribute to headers that originate as markdown-ish things (i.e. 1-6
#s).It targets only initial string elements of the
contentparameter forcaph: https://github.com/bakpakin/mendoza/blob/2c0010a3e84cab860651da8b961410a2f84abaf4/mendoza/markup.janet#L73All it does is strip occurences of the space character. Thus it's true that there is potential for collisions.
If that's a concern worth addressing, perhaps there could be a table that's populated and checked for collisions. For a collision, possibly some string can be appended to the checked name and the result could be checked against the table (possibly leading to further checks and appending -- but this should terminate at some point).
I'm not so sure collisions would be that frequent. Though perhaps there are some cases where people want to use the same header names within a page or that space removal could lead to collisions. For the latter case, perhaps that makes replacing inner spaces with
-characters a better alternative.An alternative approach to trying to come up with non-colliding names automatically might be to halt processing and inform the user that there was a name collision -- though it seems this would also require something like a table.