search

bakpakin / tiny-ecs

ECS for Lua
http://bakpakin.github.io/tiny-ecs/doc/
MIT License
675 stars 61 forks source link

Fix init.lua #19

Closed wqferr closed 5 years ago

wqferr commented 5 years ago

Fixes #18

Allows tiny-ecs to be imported as a submodule.

bakpakin commented 5 years ago

Thanks, I will merge this. I swear I used init.lua for exactly this purpose before, but it doesn't seem to work anymore. I've also verified this change works with the latest LOVE2D, as well as Lua 5.3, but not with other versions of Lua out of the box with a default package.path (on Arch Linux).

wqferr commented 5 years ago

Maybe it was undefined behavior, calling a method on multiple values in (...):match. Regardless, thanks for the quick reply!

wqferr commented 5 years ago

Also, should this get a new release tag?

bakpakin commented 5 years ago

Maybe, but init.lua is not even referenced by luarocks, so it should be no different.

wqferr commented 5 years ago

I was thinking more for use as a submodule. Git can get finnicky if you checkout a submodule branch instead of a tag.

But it's not a big deal, it only really matters when there's frequent updates, and the project seems really stable nowadays.