bakrun / stackitem64

stack item 64 minecraft
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Feature request: make it configurable which items to stack, and configurable stacksize #1

Closed Zevac-ZSF closed 1 month ago

Zevac-ZSF commented 1 month ago

Hello, nice mod :-)

Can you make it possible to configure which items to stack and which not?

And to configure the max stack size per item?

Example, I would only like to stack lave, snow, water buckets to 16, nothing else

Thank you in advance :-)

Z.

bakrun commented 1 month ago

I will be try to that

bakrun commented 1 month ago

It is possible to configure which items to stack

config/stackitem.json5 file use

Zevac-ZSF commented 1 month ago

I just tested it, it works great with the full buckets ! Thank you :-)

I did find something strange. Shulkerbox stacking is handled via Carpet mod (by Gnembon), it stacks on the ground, but not inside containers (ea hoppers, chests etc). But your code changed that. it now also stacks inside containers. Can you fix that?

Thank you again :-)

bakrun commented 1 month ago

maybe minecraft/config/stackitem.json5 modify delete shulkerbox, or shulkerbox stack to 1

Zevac-ZSF commented 1 month ago

I already tried that, same result shulkerboxes stack inside containers to 64:

{ "ItemName": ["minecraft:water_bucket","minecraft:lava_bucket","minecraft:powder_snow_bucket","minecraft:milk_bucket"], "ItemStack": [16,16,16,16] }

and

{ "ItemName": ["minecraft:water_bucket","minecraft:lava_bucket","minecraft:powder_snow_bucket","minecraft:milk_bucket","minecraft:shulker_box"], "ItemStack": [16,16,16,16,1] }

now I think about that, that is kinda weird, shulkerboxes to 1, didn't seem to have any effect.

bakrun commented 1 month ago

Is Carpet mod default stackableShulkerBoxes true? check carpet mod rules

Zevac-ZSF commented 1 month ago

Yes, I did not change anything in Carpet. so default stackableShulkerBoxes=true, as it has been for years now :-)

Zevac-ZSF commented 1 month ago

I've used several stackable mods over the years, and all worked fine with Carpet. I always only stacked filled buckets to 16, and left Carpet to deal with the Shulkerboxes. Last one I used was Stackables by Roundaround (for MC 1.20.1), but sadly he's not updating soon. Maybe you can compare code?

bakrun commented 1 month ago

this issue isnew vanilla feature in 1.20.5+ this

if return shulkerbox behavior use this mod

Zevac-ZSF commented 1 month ago

wow, I did not know that, thank you !!!

Zevac-ZSF commented 1 month ago

Mmm... I'd prefer to lessen the amount of mods I need, it is always am issue with updating... I think I'll keep using your mod, and set the shulkerboxes to 4 or 16.

Thank you for all your help, I hope your mod will become succesful!

Z.