bakulf / bbox

...something like dropbox based on subversion.
http://bbox.nois3lab.it
Other
36 stars 4 forks source link

Windows client ignoring filenames with accented characters #27

Open VTol-zz opened 12 years ago

VTol-zz commented 12 years ago

In Windows 7 32bit, only files with "english" filenames are commited into repository (synced), while those with special characters (code page 1250 in my case) are ignored (even not added to SVN). I thought VS 2010 uses unicode encoding under all conditions, so I am confused, why this could be possible - but I experience it.

Another minor issue I have with BBox: when I want to delete any file, which was commited before, it is almost impossible, becase autocommit feature updates it back from the repository. The only way I found is to commit this change (deletion) by separate SVN client.

bakulf commented 12 years ago

Thanks for the patch! I'm reviewing it and soon I'll integrate it!

hisaha commented 12 years ago

I am not sure this problem is solved or not. I have almost same situation. I modified main.cpp like below, and it works well in Japanese windows 7 pro 64bit.

--main.cpp-- BBApplication app(argc, argv); QTextCodec::setCodecForCStrings(QTextCodec::codecForLocale());

bakulf commented 12 years ago

Thanks for this patch! I'll test it properly and I'll release a new version!

b

hisaha commented 12 years ago

So, I also checked my code on OSX. It works well but a configuration is additionally required. If the user unset the environment variable of LANG, the qprocess class only could handle ascii character of standard output (from bbsvn class). In my environment (Japanese OSX), the below settings are required. cd ~ mkdir .MacOSX cd .MacOSX vi environment.plist

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>LANG</key>
<string>ja_JP.UTF-8</string>
</dict>
</plist>

after this edit, it is need to log off/on. Currently BBox works perfectly in my Japanese PC and Mac! Thanks!

bakulf commented 12 years ago

wow Tnx! I'll create a new build soon with your patch!

b

l0co commented 12 years ago

Is the version on website for download already with this path applied or not? Can you notify here when it's ready? Thanks.

bakulf commented 12 years ago

Is the version on website for download already with this path applied or not? Can you notify here when it's ready? Thanks.

Not yet. But I'll write you (and here) when I update the new version. b