search

bal3no / TrasmissioneFatture

TrasmissioneFatture wsdltophp
1 stars 0 forks source link

Coding convention #3

Closed baiolo closed 5 years ago

baiolo commented 5 years ago

Classes are named with a mix of coding conventions, Eg: ErroreInvio_Type.php. Should we use CamelCase or Snake_Case ?

bal3no commented 5 years ago

Yes, that's exactly what I think too. You can try to contribute with a PR on https://github.com/WsdlToPhp/PackageGenerator

bal3no commented 5 years ago

just to avoid mistakes, snake case should have only the first letter either upper or lowercase, so the correct class name can to be ErroreInvioType or Errore_invio_type

baiolo commented 5 years ago

Why i shoud contribute to another repository if the mistakes are in this repository. May be the mantainer of the other repo is more polite than you @bal3no.