balakethelock / SuperWoW

1.12.1 WoW client mod that expands on API functionalities
Other
31 stars 2 forks source link

[BUG] Player character targeting occasionally buggy #4

Open RUTHINAS opened 2 months ago

RUTHINAS commented 2 months ago

Describe the bug Every now and then I come across a player character that can not be targeted regularly. Clicking on the character will select them as a target, and any spell casts will act normally, but the target frame will not be displayed. Additionally, the tooltip when hovering over the character will display as if the character was a world object (like a bonfire or a signpost), meaning that TinyTip does not alter the tooltip in any way like it does for all other characters.

Relogging fixes it for the individual character in question, but typically another character close by has the same feature. It seems that the affected character is always someone near the player when logging in. Reloading the UI has no effect, the same characters seem to retain the bug after reload. The affected characters do not seem to share any specific traits with one another.

Expected behavior Targeting should behave normally for all characters.

Additional context The issue appeared with the introduction of SuperWoW & VanillaTweaks to my setup. Beyond that no other changes have been made.

irregular targeting Here you see a character with the described behavior: regular tooltip (i.e. without addon features from TinyTip), no target frame (should be at the bottom of the screenshot). Of note is that the character's target-of-target is displayed (bottom left).

regular targeting Here you see a character without the bug. Tooltip has all the TinyTip features, target frame is visible, target-of-target is shown when applicable (not the case in the attached screenshot).

balakethelock commented 2 months ago

What do normal functions that can take "Target" argument for these players, for example what happens why you do /print UnitName("target") Same question if you mouseover them & type UnitName("mouseover") or invite them to party & type UnitName("party1")

My first guess is maybe this is a bug with "target" argument randomly doesn't work for certain players, so when the interface finds UnitExists("target") return false it doesn't draw the target frame? For sure the client is indeed targetting that player because spells are targeting it + the selection circle appears underneath.

It might help to clear wdb.

Yet another question: does it ever happen with mobs or only with players.

RUTHINAS commented 2 months ago

Seems to happen with players exclusively. I didn't get a chance to test very thoroughly yet, but a macro that does a UnitExists("target") and a UnitIsFriendly("target","player") check fails to run on bugged targets.

Bad WDB data is not the issue, I have the client set up to never even create WDB caches – a lack of it could be the culprit, but it would nevertheless be a bug that has never happened before.

RUTHINAS commented 2 months ago

I grouped with a player character that was displaying the bug. While not in party, the target frame did not become visible, and it stayed invisible after the player accepted the party invite. However, retargeting fixed that and the target frame behaved normally from then on, until I disbanded the party and it was reverted to its bugged behavior. Additionally, the party frames worked perfectly well from the start.

In this case the target was from the opposite faction, but that has not been the case for all characters exhibiting the bug.

balakethelock commented 2 months ago

https://github.com/balakethelock/SuperWoW/releases/tag/Release

Hopefully this release fixes it

liaochaofeng commented 3 weeks ago

The problem has been there for a long time, and I hope to fix the bug ![Uploading WoWScrnShot_061124_223549.jpg…]()