search

balance-io / balance-manager

A tool to manage your wallets
https://manager.balance.io
GNU General Public License v3.0
143 stars 84 forks source link

💳 Offer loans powered by Dharma #195

Open ricburton opened 6 years ago

ricburton commented 6 years ago

Bad debt is bad. Good debt is good. Dharma.io is creating a marketplace for debt on Ethereum. We should help our customers get access to sensible sums of capital with fair interest rates.

ricburton commented 6 years ago

I would like to get a really rough prototype of this working as soon as possible.

It would recreate much of Dharma's Plex: https://plex.dharma.io/

Discussion here: https://spectrum.chat/balance?thread=ffe545e8-46cb-45f8-a444-a5bf7d67df41

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 6.0 ETH (3718.09 USD @ $619.68/ETH) attached to it.

ricburton commented 6 years ago

Additional Details

Definition of Done

Reviewers @jinrummie @ricburton

loan options

loan request

loan details

loan payment

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 9 months ago. Please review their action plans below:

1) travisdmathis has started work.

will begin per agreements made on slack.

Learn more on the Gitcoin Issue Details page.

cooganb commented 6 years ago

@ricburton What's the status of this? Have you found someone to do the entire project?

amhed commented 6 years ago

I think each of the tabs should be its own issue (collateralised, token based, share based, and bloom).

I would start with the simplest possible loan. Using collateralised loans as the only option within the loans tab. Why? because:

Providing simple loans would require the following screens:

I would also encourage these screens to contain unit tests. I know we still don't have a clear convention for tests because of a refactoring, but it wouldn't hurt to start adding test coverage.

amhed commented 6 years ago

I only listed screens. We don't need to write the API, we can use dharma.js and pass the transactions to the handlers for signing on the wallet being used

travisdmathis commented 6 years ago

The agreements are for MVP of Collateralized Loans using Dharma. What we see in the screens and the associated views.

ricburton commented 6 years ago

@amhed I totally agree. This project is just for the MVP with collateralised loans. @nadavhollander and the team at Dharma are hard at work on the other parts :)

travisdmathis commented 6 years ago

Day 1 Update: Finished UX/UI of Main View, Day 2 plans are to get as much of the remaining UX/UI in place so the rest of the time is spent w/ Dharma.. There may be 1 or 2 more days after today of UX/UI depending how things go.

bm

ricburton commented 6 years ago

This is amazing progress. Thank you!

Richard

On Wed, Jun 06, 2018 at 10:00:07, Travis Mathis < notifications@github.com > wrote:

Day 1 Update: Finished UX/UI of Main View, Day 2 plans are to get as much of the remaining UX/UI in place so the rest of the time is spent w/ Dharma.. There may be 1 or 2 more days after today of UX/UI depending how things go.

bm ( https://user-images.githubusercontent.com/1335198/41042668-3b042988-6970-11e8-9e89-de3e777f022c.png )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/195#issuecomment-395078832 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkIhxLlPmffjNaDoAJlFS3cjkRnQKks5t5-BngaJpZM4T8xMc ).

nadavhollander commented 6 years ago

@travisdmathis Hell ya! This looks awesome. If you're looking to integrate w/ dharma.js, I'd start looking at docs.dharma.io

Our documentation is lacking (we're overhauling it in the coming month, I promise!) but, in the meanwhile, we can invite you into our developer slack so you have 24/7 access to us if you have questions at all. I'll send an invite to your public email :)

travisdmathis commented 6 years ago

@nadavhollander i got the invite, will be diving into dharma tomorrow afternoon pending i finish the rest of UX/UI tonight/tomorrow.. thanks!

nadavhollander commented 6 years ago

Sweet!

On Thu, Jun 7, 2018 at 5:20 PM Travis Mathis notifications@github.com wrote:

@nadavhollander https://github.com/nadavhollander i got the invite, will be diving into dharma tomorrow afternoon pending i finish the rest of UX/UI tonight/tomorrow.. thanks! looking forward to diving in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balance-io/balance-manager/issues/195#issuecomment-395606220, or mute the thread https://github.com/notifications/unsubscribe-auth/ADF3Xg9gxCTmYs5vtNojiGTqJizQUhGQks5t6cNSgaJpZM4T8xMc .

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 6.0 ETH (3545.7 USD @ $590.95/ETH) has been submitted by:

  1. @travisdmathis

@ricburton please take a look at the submitted work:

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 6.0 ETH (3404.27 USD @ $567.38/ETH) attached to this issue has been approved & issued to @travisdmathis.

ricburton commented 6 years ago

Information on linking Balance and Bloqboard:

You can send it to our API: for kovan testnet: https://kovan-api.bloqboard.com/swagger/ for mainnet: https://api.bloqboard.com/swagger/

POST /api/v0/Debts is the right endpoint

just don’t forget to adapt an order to the relayer format before posting: https://github.com/confirmationlabs/dharma-example/blob/master/relayer-adapter.js

Thanks @frostiq

I really want to get this prototype fully functional and get the UI in line with the mockups. It's obviously a long way from matching them at this stage. Will need a lot more engineering to get there.