😻 Unique Tokens (Nerds call them Non-Fungible Tokens)

ricburton commented 6 years ago

We need to display our customers' kitties.

ricburton commented 6 years ago

Devin Finzer of Open Sea suggested we use this:

https://docs.opensea.io/v1.0/reference?showHidden=06ea4

ricburton commented 6 years ago

https://twitter.com/dfinzer

ricburton commented 6 years ago

loan options uniques

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 500.0 ZRX attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$10,157.71 more funded OSS Work available on the Gitcoin Issue Explorer

StevenJNPearce commented 6 years ago

I tried out the opensea API, it doesn't appear to be working, I guess it needs an API key? This issue would only be a couple of hours work for me, would be happy to pick it up.

ricburton commented 6 years ago

Hi @jesseRWeigel,

I approved you for this task as I really appreciated the tone of your application and the fact that you used GitCoin to apply 👍

I have asked the CEO of OpenSea.io for the API key.

Please can you DM me on Twitter so we can add you to our private slack: http://twitter.com/ricburton

ricburton commented 6 years ago

Someone has actually started working on this issue. He is about to post questions.

Gitcoin is a learning process! I think we are going to set a policy from now on:

All communication on GitHub. All applications on GitCoin.

Please do not work on a paid issue if you are not accepted on GitCoin.

palevoo commented 6 years ago

what happens onclick View button, does it open up a cryptokitten website for the relative cat what happens when hovered over kitty card and onclick, also what info does the first line renders apart from id is there some layout available like on figma or something, thank you very much

ricburton commented 6 years ago

what happens onclick View button, does it open up a cryptokitten website for the relative cat Opens the OpenSea.io link. For example: https://opensea.io/assets/0xf7a6e15dfd5cdd9ef12711bd757a9b6021abf643/8030

what happens when hovered over kitty card and onclick, also what info does the first line renders apart from id Can you explain this in more detail? I was just imagining the View link should open up a new tab on OpenSea.io.

is there some layout available like on figma or something, thank you very much Yep! A sketch file. Here you go: https://cl.ly/2U3l0r1W0735

palevoo commented 6 years ago

ok, thanks, will be ready in couple of hours

ricburton commented 6 years ago

I cannot wait to see my kittie!

Richard

On Wed, Jun 06, 2018 at 09:17:25, Nikita Kudryavtsev < notifications@github.com > wrote:

ok, will be ready in couple of hours

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/240#issuecomment-395064775 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkCGOrlWYwfm0jI4tbrhGckZhxicRks5t59ZkgaJpZM4UJS7M ).

calchulus commented 6 years ago

Also can't wait!! This is sick!

palevoo commented 6 years ago

everything is ready, https://github.com/decentfund/balance-manager/tree/cryptokitties but before we close the pull request, if everything is ok of course, could @ricburton move the corresponding gitcoin ticket on me @palevoo, as I would like to start gaining some rep on the platform, thanks man!

OpenSea API, doesn's show erc721 (kitty tokens) your put on market/sale, since it doesn't see them as yours. OpenSea sometimes doesn't return any images for tokens, how would you prefer to handle imgae onError fallback, shouldI install some library installed like Some possible future todos/improvements:

Add page pagination for account views
For smaller screens tab menu inside account views isn't responsive, especially with loans being added next, maybe do hamburger menu or just icons (imho think icons is cooler)

If you have any questions or feedback to change things, please don't hesitate to ask/tell.

calchulus commented 6 years ago

wooo! can't wait to screenshot with my awesome cryptokitties

On Thu, Jun 7, 2018 12:40 PM, Nikita Kudryavtsev notifications@github.com wrote: everything is ready, https://github.com/decentfund/balance-manager/tree/cryptokitties but before we close the pull request, if everything is ok of course, could @ricburton move the corresponding gitcoin ticket on me @palevoo, as I would like to start gaining some rep on the platform, thanks man!

OpenSea API, doesn's show erc721 (kitty tokens) your put on market/sale, since it doesn't see them as yours. OpenSea sometimes doesn't return any images for tokens, how would you prefer to handle imgae onError fallback, shouldI install some library installed like Some possible future todos/improvements:

Add page pagination for account views
For smaller screens tab menu inside account views isn't responsive, especially with loans being added next, maybe do hamburger menu or just icons (imho think icons is cooler)

If you have any questions or feedback to change things, please don't hesitate to ask/tell.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ricburton commented 6 years ago

I don't currently see my kittie, spoop, popping up.

https://opensea.io/assets/0x06012c8cf97bead5deae237070f9587f8e7a266d/17753

A separate issue, we should fall back to english when we don't have a translation.

Can I help you debug this?

Can you submit a pull request for this work as it progresses? That way, Netlify, the system we use for playing with builds, will load up the UI and allow me to test it.

alexanderatallah commented 6 years ago

@ricburton I made an API key for you to make sure you don't get excessively rate-limited in the future - sent it to you in a twitter DM. It needs to be sent as the value of an HTTP header called "X_API_KEY"

To address this issue,

doesn's show erc721 (kitty tokens) your put on market/sale, since it doesn't see them as yours.

I'll fix this now so assets you're selling will show up too!

ricburton commented 6 years ago

Thanks @alexanderatallah!

@palevoo, @jinchung and I need to think about the smart way to manage keys and help our open source contributors use them but not have access to them.

For now, I'll get in contact with you privately to give you the key 👍

palevoo commented 6 years ago

Pull request submitted @ricburton for the calls to the openSea api from localhost you would need some form of cors i use chrome extension Allow-Control-Allow-Origin otherwise it blocks it.

ricburton commented 6 years ago

Spoop is in the house! This is great :)

Adding you to our company slack so we can share the API key and think about best way forward.

Richard

On Thu, Jun 07, 2018 at 16:37:24, Nikita Kudryavtsev < notifications@github.com > wrote:

Pull request submitted @ ricburton ( https://github.com/ricburton ) for the calls to the openSea api from localhost you would need some form of cors i use chrome extension Allow-Control-Allow-Origin otherwise it blocks it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/240#issuecomment-395556633 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkIIIB014S00_Xls3gRJVp28hMqObks5t6Y8EgaJpZM4UJS7M ).

ricburton commented 6 years ago

Can you DM me on Twitter? twitter.com/ricburton ( http://twitter.com/ricburton )

Richard

On Thu, Jun 07, 2018 at 16:42:07, Richard Burton < richard@balance.io > wrote:

Spoop is in the house! This is great :)

Adding you to our company slack so we can share the API key and think about best way forward.

Richard

On Thu, Jun 07, 2018 at 16:37:24, Nikita Kudryavtsev < notifications@ github. com ( notifications@github.com ) > wrote:

Pull request submitted @ ricburton ( https://github.com/ricburton ) for the calls to the openSea api from localhost you would need some form of cors i use chrome extension Allow-Control-Allow-Origin otherwise it blocks it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/240#issuecomment-395556633 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkIIIB014S00_Xls3gRJVp28hMqObks5t6Y8EgaJpZM4UJS7M ).

alexanderatallah commented 6 years ago

@palevoo we've been whitelisting domains on a case-by-case basis while the API is in beta, but I just pushed a change to open up CORS access to anyone, so it should work now. sorry about that!

@ricburton FYI the API key is gonna be visible in the network logs and in your source code, so safeguarding it isn't a necessity, it's just a deterrent. I just didn't wanna share it here to prevent Google from indexing it

gitcoinbot commented 6 years ago

@JesseRWeigel Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

ricburton commented 6 years ago

Jesse has moved on to another issue.

Please assign this to @palevoo.

Richard

Sent via Superhuman ( https://sprh.mn/?vip=richard@balance.io )

On Sat, Jun 09, 2018 at 12:15:17, Gitcoin.co Bot < notifications@github.com > wrote:

@ JesseRWeigel ( https://github.com/JesseRWeigel ) Hello from Gitcoin Core

are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

warning (3 days)

escalation to mods (6 days)

Funders only: Snooze warnings for 1 day ( https://gitcoin.co/issue/balance-io/balance-manager/240/571?snooze=1 ) | 3 days ( https://gitcoin.co/issue/balance-io/balance-manager/240/571?snooze=3 ) | 5 days ( https://gitcoin.co/issue/balance-io/balance-manager/240/571?snooze=5 ) | 10 days ( https://gitcoin.co/issue/balance-io/balance-manager/240/571?snooze=10 ) | 100 days ( https://gitcoin.co/issue/balance-io/balance-manager/240/571?snooze=100 )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/240#issuecomment-395980830 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkEtqRc23LwosHewsA60GRp0ti_Gjks5t6_SVgaJpZM4UJS7M ).

vs77bb commented 6 years ago

:+1: @palevoo Would you mind clicking 'Start Work' on Gitcoin here?

By the looks of it, you can also 'Submit Work' thereafter, referencing your PR. If you need some initial gas to make this submission, check out the Gitcoin Faucet. 🙂

palevoo commented 6 years ago

@vs77bb there is no such option/button as 'Start Work'

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 8 months, 3 weeks ago. Please review their action plans below:

1) palevoo has been approved to start work.

Its done :)

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 500.0 ZRX (625.0 USD @ $1.25/ZRX) has been submitted by:

@ricburton please take a look at the submitted work:

PR by @palevoo
(Link Not Provided) by @palevoo

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack $24,326.70 more funded OSS Work available on the Gitcoin Issue Explorer

igorline commented 6 years ago

Getting CORS error in production

ricburton commented 6 years ago

Ugh. This API is so bad. @jinrummie?

Can you show logs? On 15 Jun 2018, 08:08 -0400, Igor Line notifications@github.com, wrote:

Getting CORS error in production — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

igorline commented 6 years ago

@ricburton, here it is balance_io_cors

ricburton commented 6 years ago

Thanks Igor. It seems to work now live?

Richard

Sent via Superhuman ( https://sprh.mn/?vip=richard@balance.io )

On Mon, Jun 18, 2018 at 4:46 AM, Igor Line < notifications@github.com > wrote:

@ ricburton ( https://github.com/ricburton ) , here it is balance_io_cors ( https://user-images.githubusercontent.com/1465430/41534207-fdabcc52-72fd-11e8-8f29-32c357d69bcb.jpg )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/240#issuecomment-398027775 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkAUCjCEkSmNjTOy7lXOx7C8MeBAoks5t95MngaJpZM4UJS7M ).

igorline commented 6 years ago

@ricburton the issue is related to firefox, it displays my unique tokens in chrome

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 500.0 ZRX (665.0 USD @ $1.33/ZRX) attached to this issue has been approved & issued to @palevoo.

Learn more at on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$26,020.79 more funded OSS Work available on the Gitcoin Issue Explorer

balance-io / balance-manager

😻 Unique Tokens (Nerds call them Non-Fungible Tokens) #240