search

balance-io / balance-manager

A tool to manage your wallets
https://manager.balance.io
GNU General Public License v3.0
143 stars 84 forks source link

Auto Refresh #318

Closed timoUK closed 6 years ago

timoUK commented 6 years ago

What is this issue about? (select one)

Issue Description

Would be good if Manager auto-refreshed, I have to refresh it to see new transactions. Could be done by automatically refreshing when a button or tab is clicked.

jdkanani commented 6 years ago

Use bulk request to refresh transactions/token balances. One way to do this - use wrapper on top of the provider which queue transactions and sends them at the certain interval.

That way new devs don't have to worry about intervals etc. One wrapper will handle internally all of those things.

ricburton commented 6 years ago

@jdkanani I like this a lot. We definitely have work to do here.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

octavioamu commented 6 years ago

Could be something like this? Is the behavior really to reload the page (cmd+r but with a button)? image

jdkanani commented 6 years ago

Use bulk request to refresh transactions/token balances. One way to do this - use wrapper on top of the provider which queue transactions and sends them at the certain interval

I was referring to refresh txs/token balances auto-magically when new transaction detected on given account on the blockchain. To me CMD + R (asked non-tech friend too) is more intuitive than "Reload" button. But @ricburton would be best person to take this call.

octavioamu commented 6 years ago

Ok, the thing with CMD is because is only Mac OS based. Also maybe can be without a word, only icon.

ricburton commented 6 years ago

Great point on the Command + option. We should adapt that for Windows and Linux. Will create an issue.

Richard

On Fri, Jul 13, 2018 at 09:52:53, Octavio Amuchástegui < notifications@github.com > wrote:

Ok, the thing with CMD is because is only Mac OS based. Also maybe can be without a word, only icon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404839979 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkCMgHCbNMIRi-fZ4UKc6GvgPn9ZPks5uGKY1gaJpZM4UyTow ).

ricburton commented 6 years ago

Created: https://github.com/balance-io/balance-manager/issues/350

Richard

On Fri, Jul 13, 2018 at 10:13:24, Richard Burton < richard@balance.io > wrote:

Great point on the Command + option. We should adapt that for Windows and Linux. Will create an issue.

Richard

On Fri, Jul 13, 2018 at 09:52:53, Octavio Amuchástegui < notifications@ github. com ( notifications@github.com ) > wrote:

Ok, the thing with CMD is because is only Mac OS based. Also maybe can be without a word, only icon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404839979 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkCMgHCbNMIRi-fZ4UKc6GvgPn9ZPks5uGKY1gaJpZM4UyTow ).

octavioamu commented 6 years ago

I had changed the icon to be similar to the one in the browser and changed to "refresh" image

ricburton commented 6 years ago

So we don't really want a button so much as the app itself to be live and refreshed.

I am not sure on the best way to approach this. Just wanted to attract minds to the problem using Gitcoin.

@jinchung will chime in here when she has time.

Richard

On Fri, Jul 13, 2018 at 10:29:00, Octavio Amuchástegui < notifications@github.com > wrote:

I had changed the icon to be similar to the one in the browser and changed to "refresh" image ( https://user-images.githubusercontent.com/1358093/42696824-bb699e3c-868f-11e8-88d3-1b03b0f91c92.png )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404849962 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkIhOR_ujuqSg1KlTe07BegohMydEks5uGK6sgaJpZM4UyTow ).

octavioamu commented 6 years ago

Ok I will do a WIP PR with the last one.

octavioamu commented 6 years ago

I had added translations too using google translation I only can really affirm my languages (Spanish, Portuguese BR)

ricburton commented 6 years ago

I think there has been some miscommunication here. Sorry!

We need a fresh app. Not a refresh button.

Richard

On Fri, Jul 13, 2018 at 13:09:02, Octavio Amuchástegui < notifications@github.com > wrote:

I had added translations too using google translation I only can really affirm my languages (Spanish, Portuguese BR)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404895058 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkBEYvlOsTUhMgBxvLMEtxqiuY2C_ks5uGNQtgaJpZM4UyTow ).

octavioamu commented 6 years ago

Can you please explain more what the task is? Maybe some example, is not a reload button? and when clicked the page reloads?

octavioamu commented 6 years ago

Trying to understand what the task request I think is: WHAT "As a user, I need to be able to have recent transitions of my wallet without having to refresh the windows app" HOW "every time I change the route of the app (transition to another area) the main data need to be fetched again go have the new data"

That's right??

octavioamu commented 6 years ago

I will let it go this one since I don't want to avoid other people to lose the opportunity to solve the issue. If I discover what you guys exactly want and isn't solved I can take it again.

ricburton commented 6 years ago

Sorry about the hassle here On 13 Jul 2018, 19:05 -0400, Octavio Amuchástegui notifications@github.com, wrote:

I will let it go this one since I don't want to avoid other people to lose the opportunity to solve the issue. If I discover what you guys exactly want and isn't solved I can take it again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 days, 1 hour from now. Please review their questions below:

  1. SamSamskies has started work.
    • Q: Heads up that I'll need to familiarize myself with the codebase first. I haven't looked at it yet. If this is really urgent, let me know and I can release it. This is also my first bounty request on Gitcoin, so still need to figure out the workflow.
ricburton commented 6 years ago

Not super urgent! Just keen for smart people to take a look :)

Richard

On Fri, Jul 13, 2018 at 21:06:42, Gitcoin.co Bot < notifications@github.com > wrote:

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 5 days, 17 hours from now. Please review their questions below:

  • SamSamskies ( https://gitcoin.co/profile/SamSamskies ) has started work.

  • Q: Heads up that I'll need to familiarize myself with the codebase first. I haven't looked at it yet. If this is really urgent, let me know and I can release it. This is also my first bounty request on Gitcoin, so still need to figure out the workflow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404987622 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkGT2Qz9lwjWGqaaglocRUOLLu8M2ks5uGUQigaJpZM4UyTow ).

SamSamskies commented 6 years ago

How do you do test transactions for Trezor and Ledger? I'm working on Metamask first since I know how to use Rinkeby testnet with that.

ricburton commented 6 years ago

We can do that. We have the hardware. On 13 Jul 2018, 23:05 -0400, SamSamskies notifications@github.com, wrote:

How do you do test transactions for Trezor and Ledger? I'm working on Metamask first since I know how to use Rinkeby testnet with that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

SamSamskies commented 6 years ago

How can I test that my code works as I develop though? Should I just work on Metamask for this ticket?

SamSamskies commented 6 years ago

I got it updating when clicking anywhere on the page. Seems kind of arbitrary, but so does refreshing when clicking on the tabs or buttons. How bout I just refresh the account info on an interval? Maybe every second?

ricburton commented 6 years ago

I think I have done a really bad job of explaining this issue.

We don't want the app to randomly reload. We want the data to be fresh. The page should be updating naturally, not in forced way.

Sorry everyone. I will go over it with the team.

Richard

On Sat, Jul 14, 2018 at 00:26:12, SamSamskies < notifications@github.com > wrote:

I got it updating when clicking anywhere on the page. Seems kind of arbitrary, but so does refreshing when clicking on the tabs or buttons. How bout I just refresh the account info on an interval? Maybe every second?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/318#issuecomment-404997709 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkBqxveadvyYKpTzsSSzwGAZ5plVUks5uGXLkgaJpZM4UyTow ).

SamSamskies commented 6 years ago

That's what I ended up doing if you take a look at the code I submitted. It refreshes the account data every second. It doesn't reload the page. Maybe I'm still misunderstanding though. Including more detailed descriptions in the issue along with pictures will help.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by:

  1. @SamSamskies

@ricburton please take a look at the submitted work:

StevenJNPearce commented 6 years ago

@SamSamskies It doesn't make any sense to refresh data every second when block times are every ~15 seconds.

SamSamskies commented 6 years ago

It would help to make a suggestion along with criticism. I figured that refreshing every second is a bit much, but I just wanted to get some code in to get the discussion started. Especially since I didn't know if this was the desired behavior which apparently it is not.

I'm going to release this so someone else can work on it. Good luck with the project.

ricburton commented 6 years ago

Apologies everyone. We are heads down on Wallet and this is something I thought would be quick and easy.

We will review this properly ASAP.

Maintaining and monetising open source is a new thing for all of us.

On Tue, Jul 17, 2018 at 2:48 AM, SamSamskies notifications@github.com wrote:

I'm going to release this so someone else can work on it. Communication is really bad here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/balance-io/balance-manager/issues/318#issuecomment-405478047, or mute the thread https://github.com/notifications/unsubscribe-auth/AAavkPnq-REwSPzS9gWzQOeVW9E2ao1Kks5uHYjagaJpZM4UyTow .

-- Richard

tluthra commented 6 years ago

took a stab at adding a block subscriber and adding refresh, let me know if this was more aligned with what everybody had in mind

https://github.com/balance-io/balance-manager/pull/356

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter