balance-io / balance-manager

A tool to manage your wallets
https://manager.balance.io
GNU General Public License v3.0
143 stars 84 forks source link

WalletConnect: QR-Code changes #368

Open ligi opened 6 years ago

ligi commented 6 years ago

What is this issue about? (select one)

Issue Description

The sessionId and shared key change every 60 seconds

Steps to reproduce

  1. open balance manager
  2. click WalletConnect
  3. wait 60s

Expected Behavior

The sessionId and sharedKey should stay stable

 Actual Behavior

the sessionId and sharedKey change every 60s - this will lead to very bad UX when users scan at second <60 and selects the account at second >60 as far as I see (don't have any iOS device to really verify this an AFAIK currently there is only iOS officially supported - but I would bet this is a problem)