balance-io / balance-manager

A tool to manage your wallets
https://manager.balance.io
GNU General Public License v3.0
143 stars 84 forks source link

Detect mobile dapp browser app and provide custom button #413

Open jackjdleslie opened 6 years ago

jackjdleslie commented 6 years ago

What is this issue about? (select one)

Issue Description

If you use manager.balance.io on mobile, you either:

  1. Use Safari (or something similar) and get the option to connect to Trust Wallet, which does nothing at the moment, and use WalletConnect
  2. Use Trust Wallet, Status, Coinbase Wallet (or something similar) and get the same options, except if you press the Trust Wallet button it connects regardless of the dapp browser you use.

How about if instead of just showing the Trust Wallet button regardless, you detect which browser you are using (for this example, Safari, Trust Wallet, Status) and change the button accordingly:

1. Using Safari - Don't need to show Trust Wallet button

img_4411

2. Using Trust Wallet - detect and customise button

img_4413

3. Using Status - detect and customise button

img_4412

4. Using other (e.g Coinbase Wallet) - not officially supported so default button

img_4414

Steps to reproduce

Temporarily test it on http://boiling-caverns-82152.herokuapp.com/

jinchung commented 6 years ago

@ricburton

jackjdleslie commented 6 years ago

Addressed in #414