balance-io / balance-wallet

A mobile wallet for dapps & tokens.
https://balance.io
GNU General Public License v3.0
94 stars 38 forks source link

0.5 App goes blank if WalletConnect eth_sign is malformed #363

Open localcryptosMichael opened 5 years ago

localcryptosMichael commented 5 years ago

Example of a malformed payload (data should be a string):

{"jsonrpc":"2.0","params":["0x85a7d350ea139c87e7ae669ed3a6ba6efc90bfb3",{"type":"Buffer","data":[94,87,98,227,138,241,63,71,115,180,18,98,150,96,32,84,118,160,121,118,59,67,70,5,231,2,47,192,191,73,58,190]}],"method":"eth_sign","id":1548468320799086}

Result:

image 2019-01-26 13 13 17

localcryptosMichael commented 5 years ago

Note: Same thing happens if the payload's method isn't a real method.