balance-io / balance-wallet

A mobile wallet for dapps & tokens.
https://balance.io
GNU General Public License v3.0
94 stars 38 forks source link

Change swipe navigation to react-navigation's material navigation #413

Closed osdnk closed 5 years ago

osdnk commented 5 years ago

I see no deep motivation for createSwipeNavigation component.

I believe that actually it's not a very good idea to use FlatList component here since it's not made for this purpose. Of course, it's possible to make some transitions with it, but it does not support many things which are important for natural behaviors (like omitting jitters etc.) especially initial velocity of movement, which may provide do unwanted effects.

However, I see two main reasons createSwipeNavigation has been made (if there's anything else, please let me know).

First one is setting StatusBar style which I actually achieved in another way by adding hooks via special HOC.

Another thing is blocking any other navigation interactions with resumeNavigationActions and pauseNavigationActions. It's actually done "for free" with react-navigation.