search

balance-io / balance-wallet

A mobile wallet for dapps & tokens.
https://balance.io
GNU General Public License v3.0
94 stars 38 forks source link

Extremely dirty workaround for not responsive nav buttons #425

Open osdnk opened 5 years ago

osdnk commented 5 years ago

I have observed some race condition on jumping between tabs using two methods (with swipe and navbuttons) and noticed that sometimes index of tab is incorrect. Probably it's an internal bug since it's not related to any app logic.

Of course, it's not recommendable to write it manually, but 🤷‍♀️

ricburton commented 5 years ago

Filthy 😂

Richard On 9 Feb 2019, 13:15 -0500, Michał Osadnik notifications@github.com, wrote:

You can view, comment on, or merge this pull request online at: https://github.com/balance-io/balance-wallet/pull/425 Commit Summary

• Extremely dirty workaround for not responsive nav buttons

File Changes

• M src/App.js (2) • M src/components/header/CameraHeaderButton.js (5) • M src/components/header/ProfileHeaderButton.js (7) • M src/screens/ProfileScreenWithData.js (5) • M src/screens/QRScannerScreenWithData.js (6) • M src/screens/WalletScreen.js (6)

Patch Links:

• https://github.com/balance-io/balance-wallet/pull/425.patch • https://github.com/balance-io/balance-wallet/pull/425.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.