search

balance-io / old-balance-ios

Balance in Swift
GNU General Public License v3.0
49 stars 16 forks source link

Edit wallet names #118

Closed ricburton closed 5 years ago

ricburton commented 5 years ago

Add an option to the wallet popover screen above Share

borwahs commented 5 years ago

I can jump on this issue.

einsteinx2 commented 5 years ago

@borwahs go for it :)

Looks like we'll need the extra button to pop up either an alert view with a text field to edit or a custom UI (might need input from @ricburton on that)

borwahs commented 5 years ago

@einsteinx2 - yeah, I am thinking of trying something simple with just making the Label field editable on the pop up. But that also might be a bit “hacky” feeling. I can play around with it. Any suggestions @ricburton, let me know!

borwahs commented 5 years ago

haven’t thought up a good idea. I am not sure an Edit button will fit on the SE screen size.

maybe a settings icon that flips the qr code and can edit?

@ricburton

einsteinx2 commented 5 years ago

@borwahs as discussed in Discord, you can just use a simple UIAlertViewController with a name text field and cancel/save buttons