search

balance-io / old-balance-ios

Balance in Swift
GNU General Public License v3.0
49 stars 16 forks source link

Use Monospace font for Address Labels #127

Open borwahs opened 5 years ago

borwahs commented 5 years ago
borwahs commented 5 years ago

On it. Was debating whether to build an extension and change the existing ones.

borwahs commented 5 years ago

See comparison of pre and post Menlo usage below.

Couple of notes:

pre-new prepost2

borwahs commented 5 years ago

Thoughts on changing the CDP Modal Info view numbers to the monospace font?

ricburton commented 5 years ago

Totally agree @borwahs. There are lots of places where I want to use monospaced fonts and this really helps me see how to do it. Thanks!

I'll let Ben review this before merging.

ricburton commented 5 years ago

Really interesting discussion here: https://stackoverflow.com/questions/38148073/uifont-monospaceddigitsystemfontofsize-not-really-monospaced

In all the designs I use SF Mono but that is actually not allowed apart from on Apple's products.

I think we need to find a monospaced font that works well for the project.

I tweeted about this before. Will look at the suggestions.

borwahs commented 5 years ago

@ricburton // nice find on that SO question. I was confused why monospaced system don’t was not actually using it. Looks like the adjust font to size of container option breaks it.

einsteinx2 commented 5 years ago

Yeah it’s really annoying they don’t make it available... we snuck it into balance for Mac and they approved it but they could reject at any time so it’s better to find a different one that’s fully allowed

einsteinx2 commented 5 years ago

Will hold off on merging this until we settle on the font we want.

einsteinx2 commented 5 years ago

Also for the name of the extension swift file, I accidentally wrote UIFont-Monospaced.swift when it should be UIFont+Monospaced.swift

borwahs commented 5 years ago

I did something odd here. I think I might have not branched off of develop. Not sure why there are so many conflicts. Going to look into it and repush.

borwahs commented 5 years ago

fixed merge issues. think i accidentally rebased master at some point.

einsteinx2 commented 5 years ago

@ricburton are you happy with Menlo as the font?