search

balance-io / old-balance-ios

Balance in Swift
GNU General Public License v3.0
49 stars 16 forks source link

Add Ability to Edit Wallet Name (#118) #150

Closed borwahs closed 5 years ago

borwahs commented 5 years ago

Closes #118

borwahs commented 5 years ago

Special case for iPhone SE:

Screen Shot 2019-04-01 at 6 18 04 PM
borwahs commented 5 years ago

@einsteinx2 // two things:

  1. I cannot figure out why the labels on the bottom two buttons are inset slightly.
  2. I used a closure so we didn't have to couple CoreData logic into the UIView.
borwahs commented 5 years ago

Also, @ricburton do you have an icon I can use for the Edit button?

ricburton commented 5 years ago
renameButtonIcon@2x

renameButtonIcon@3x

Here you go @borwahs!

borwahs commented 5 years ago

@ricburton /// could you provide a version without white background? Or, if it's in the Figma, I can pull it from there.

Screen Shot 2019-04-02 at 1 43 10 PM
ricburton commented 5 years ago

Sorry! Will Do shortly.

ricburton commented 5 years ago

renameButtonIcon@3x

renameButtonIcon@2x
borwahs commented 5 years ago

@einsteinx2 & @ricburton // this is ready for your review. Added the transparent icon.

ricburton commented 5 years ago

Sweet will dive in first thing tomorrow.

einsteinx2 commented 5 years ago

@borwahs not sure why it's off, but I fixed the alignment with this:

shareButton.titleEdgeInsets = UIEdgeInsets(top: 0, left: 4, bottom: 0, right: 0)

einsteinx2 commented 5 years ago

You can use constraints on the button's image view but not the title view, have to use edge insets, but it gets the job done