search

balanced-cookbooks / balanced-ci

Internal configuration for the Jekins CI environment
4 stars 1 forks source link

Base cookbook knows too much. #4

Closed mjallday closed 10 years ago

mjallday commented 10 years ago

This change is a code smell - https://github.com/balanced-cookbooks/ci/commit/47e9c49faca07e55421a942a24b683e872592d9d

Ideally I would be able to arbitrarily set attributes on the ci_job and these would be exposed to the template. E.g. the downstream_triggers does not need to be declared in the ci cookbook.

mjallday commented 10 years ago

This was fixed by @coderanger .