balanced-cookbooks / balanced-ci

Internal configuration for the Jekins CI environment
4 stars 1 forks source link

Add promote util #40

Closed fangpenlin closed 10 years ago

fangpenlin commented 10 years ago

This basically does what this https://github.com/balanced/confucius/blob/master/fabfile.py#L25 does. You can now input PACKAGE and VERSION as build parameter. For example, billy, 1.0.3-3 and it will make the package to be in main for you.

fangpenlin commented 10 years ago

@victorlin https://wiki.jenkins-ci.org/display/JENKINS/Promoted+Builds+Plugin

mahmoudimus commented 10 years ago

ping @coderanger can we merge this in?

coderanger commented 10 years ago

I'm against it, I really don't think this is a good use ofJenkins.

mahmoudimus commented 10 years ago

@coderanger this is temporary until we can use rundeck -- see this card: https://trello.com/c/q6IJUfBl but right now, I'd like people to have 1 place to promote jobs.

coderanger commented 10 years ago

Yes, that one place is "cd to the confusius folder and run the command". "one place" doesn't have to equal "is a web page".

coderanger commented 10 years ago

Alternatively didn't you setup the build promotion plugin for this already? (which at least has some semantic meaning)

mahmoudimus commented 10 years ago

@coderanger I did but I wanted to see how @victorlin would do it. This is a testament to how easy it is to add jobs in our new ci pipeline :)

mahmoudimus commented 10 years ago

Yes, that one place is "cd to the confusius folder and run the command". "one place" doesn't have to equal "is a web page".

I agree w/ this, but we had some push back from engineers who didn't want to run the deploy cmd :) They're used to the old jenkins installation.

coderanger commented 10 years ago

Okay, so we can then close this as "mission accomplished"?

mahmoudimus commented 10 years ago

If by close, you mean "merge" :)

coderanger commented 10 years ago

No, I mean close, this was an experiment, we now know how complex it is to add new jobs, but we don't need this job in particular thanks to the build promotion plugin. Is there something else I'm missing?

fangpenlin commented 10 years ago

@mahmoudimus @coderanger I will see what I can do with that promote plugin, and create another branch which is based on plugin approach :)

coderanger commented 10 years ago

Superseded by #42