Closed fangpenlin closed 10 years ago
hmmm... I am not sure am I using promotion plugin in the correct way. Never used something like this before. I draw a diagram regarding the whole workflow here
https://github.com/balanced/balanced-dev-wiki/wiki/Continuous-Integration-Workflow-Overview
@coderanger could you have a look on this when you have spare time? and we can make some tweaks with this plugin and workflow. Thanks.
oh... okay, I think I should put the promotion in build job rather than acceptance job
oh yeah, we have promotion for build now.
@coderanger should we trigger the promotion on acceptance
pass only, or should we also require user approval to kick start a promotion?
If we need to add manual approval condition, simply add
<hudson.plugins.promoted__builds.conditions.ManualCondition>
<users></users>
<parameterDefinitions/>
</hudson.plugins.promoted__builds.conditions.ManualCondition>
in promote.xml.erb
, conditions
element.
@victorlin i believe we're going to pin the version of the deb that's installed in the environment file so auto promote should be OK on acceptance pass.
@mjallday No, the whole point is that promote is always manual and that for select projects we require a second manual step for safety.
Looks good @victorlin! @coderanger can we get a sign-off here so we can merge?
Tagged as v1.0.80 and deploying to the server now.
@coderanger
Oh, I set promotion to disable as default. Maybe we can turn it to enable by default, since I think all project needs promotion.
@victorlin I defer to @mahmoudimus on that :-)
@mahmoudimus @coderanger
Okay, this is pretty much done. Give it a look. For now, if you want to add promotion build for an acceptance job, you can simply add
promotion true
like this@coderanger By the way, it appears the AWS access key
travis/aws_access_key_id
incitadel
is deleted? I tried to run acceptance test and it failed because 403 error when kitchen uses that key to do something with aws.